[capabilities] add capabilities method to ObjectStore trait#732
Open
vitoordaz wants to merge 4 commits into
Open
[capabilities] add capabilities method to ObjectStore trait#732vitoordaz wants to merge 4 commits into
vitoordaz wants to merge 4 commits into
Conversation
I'm starting with a single capability for ordered list results. GCP and Azure list objects always return ordered results. For AWS it depends on a bucket type, for directory buckets results are not ordered. I'm thinking about adding new config option for indicating whether S3 bucket is a directory bucket or not. But for now we can say that AWS results are not ordered.
Contributor
Author
|
@alamb does this change seems reasonable to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm starting with a single capability for ordered list results.
Memory, GCP, and Azure list objects always return ordered results. Local filesystem storage uses
WalkDirwhich relies on OSreaddirsyscall that does not guarantee lexicographic order because it depends on file system.For AWS, it depends on the bucket type; for directory buckets, the results are not ordered.
I'm thinking about adding a new config option for indicating whether the S3 bucket is a directory bucket or not. But for now, we can say that AWS results are not ordered.
Which issue does this PR close?
Closes #675.
Rationale for this change
This will allow object store users to write more efficient code by leveraging underlying object store features.
What changes are included in this PR?
A new
capabilitiesmethod is added to the ObjectStore trait.Are there any user-facing changes?
This change is backward compatible.